You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What specific section or headline is this issue about?
details
What information was incorrect, unhelpful, or incomplete?
I noticed two issues, one minor and one more important. I'll start with the latter:
While the bottom of the article states that the API is based on Chromium's chrome.webNavigation API, the specs for the details object does not actually match that of Chromium.
In particular, the details object provided to listeners does not include any of the members which were added in Chromium ver 106 (documentId, documentLifecycle, etc) yet it is suggested that they should be.
The former, minor issue, is simply that the link inside the "Note" section to chrome.webNavigation has the wrong value for the fragment identifier. It's set to onBeforeNavigate, rather than onCommitted.
What did you expect to see?
I would like to see some mention of this discrepancy to some extent, as it is rather confusing. Also, on a somewhat unrelated note, it would be very helpful to have the differences in webNavigation API behavior described more as this is not the only instance.
Do you have any supporting links, references, or citations?
If desired, I would be happy to throw up a PR for the corresponding markdown file to add information about those members to make it easier for the maintainers.
MDN URL
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webNavigation/onCommitted
What specific section or headline is this issue about?
details
What information was incorrect, unhelpful, or incomplete?
I noticed two issues, one minor and one more important. I'll start with the latter:
While the bottom of the article states that the API is based on Chromium's chrome.webNavigation API, the specs for the details object does not actually match that of Chromium.
In particular, the details object provided to listeners does not include any of the members which were added in Chromium ver 106 (
documentId
,documentLifecycle
, etc) yet it is suggested that they should be.The former, minor issue, is simply that the link inside the "Note" section to chrome.webNavigation has the wrong value for the fragment identifier. It's set to
onBeforeNavigate
, rather thanonCommitted
.What did you expect to see?
I would like to see some mention of this discrepancy to some extent, as it is rather confusing. Also, on a somewhat unrelated note, it would be very helpful to have the differences in webNavigation API behavior described more as this is not the only instance.
Do you have any supporting links, references, or citations?
Chrome's API
Chrome's API Data file
Do you have anything more you want to share?
If desired, I would be happy to throw up a PR for the corresponding markdown file to add information about those members to make it easier for the maintainers.
MDN metadata
Page report details
en-us/mozilla/add-ons/webextensions/api/webnavigation/oncommitted
The text was updated successfully, but these errors were encountered: